Summary: | Remove unnecessary Timer from NetworkDataTask | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alex Christensen
2020-06-19 15:06:49 PDT
Created attachment 402332 [details]
Patch
Comment on attachment 402332 [details]
Patch
Please make sure to fix GTK/WPE/WIN
Created attachment 402570 [details]
Patch
Committed r263407: <https://trac.webkit.org/changeset/263407> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402570 [details]. Comment on attachment 402570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402570&action=review > Source/WebKit/NetworkProcess/NetworkDataTask.cpp:100 > + if (!weakThis || !m_client) > + return; Is this a safe idiom? Do we have a guarantee that we are not racing with a deref of NetworkDataTask on another thread? Comment on attachment 402570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402570&action=review >> Source/WebKit/NetworkProcess/NetworkDataTask.cpp:100 >> + return; > > Is this a safe idiom? Do we have a guarantee that we are not racing with a deref of NetworkDataTask on another thread? NetworkDataTask is always destroyed on the main thread because it uses WTF::DestructionThread::Main |