Bug 213408

Summary: [AutoSizing] Resolve viewport units against the preferred content size
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, thorton, timothy, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

zalan
Reported 2020-06-19 14:56:45 PDT
<rdar://problem/64267539>
Attachments
Patch (12.25 KB, patch)
2020-06-19 15:14 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (12.25 KB, patch)
2020-06-19 15:30 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (12.86 KB, patch)
2020-06-19 17:21 PDT, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-06-19 14:59:45 PDT
*** Bug 213313 has been marked as a duplicate of this bug. ***
zalan
Comment 2 2020-06-19 15:14:47 PDT
Created attachment 402333 [details] Patch
Tim Horton
Comment 3 2020-06-19 15:26:10 PDT
Comment on attachment 402333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402333&action=review > Source/WebCore/ChangeLog:19 > + and resolved the values against the horiztonal constraint). horiztonal > Source/WebCore/testing/Internals.cpp:3716 > +void Internals::enableSizeToContentAutoSizeMode(bool enabled, int width, int height) We already have tests. Maybe no internals method because they’re all API tests? OK
zalan
Comment 4 2020-06-19 15:30:20 PDT
Created attachment 402336 [details] Patch
zalan
Comment 5 2020-06-19 15:31:59 PDT
> > Source/WebCore/testing/Internals.cpp:3716 > > +void Internals::enableSizeToContentAutoSizeMode(bool enabled, int width, int height) > > We already have tests. Maybe no internals method because they’re all API > tests? OK Yeah, and we already have layout tests for the fixed-autosizing(mail), so I thought why not add one for the contentsize-autosizing.
zalan
Comment 6 2020-06-19 17:21:24 PDT
Created attachment 402354 [details] Patch
EWS
Comment 7 2020-06-19 17:57:40 PDT
commit-queue failed to commit attachment 402354 [details] to WebKit repository.
zalan
Comment 8 2020-06-19 19:45:00 PDT
Committed r263311: <https://trac.webkit.org/changeset/263311>
Note You need to log in before you can comment on or make changes to this bug.