Bug 213402

Summary:

Bring up watchOS/tvOS on build.webkit.org

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, dean_johnson, jlewis3, lingho, ryanhaddad, saam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=214147

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Jonathan Bedard

Reported 2020-06-19 13:18:01 PDT

Now that watchOS and tvOS can be built with the public SDK, we should include these configurations in automation.

Attachments
Patch (381.35 KB, patch) 2020-06-19 13:26 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (381.19 KB, patch) 2020-06-19 14:45 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (1.38 KB, patch) 2020-06-20 14:42 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (2.50 KB, patch) 2020-06-22 11:14 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-06-19 13:20:25 PDT

<rdar://problem/64542588>

Jonathan Bedard

Comment 2 2020-06-19 13:26:26 PDT

Created attachment 402316 [details] Patch

Aakash Jain

Comment 3 2020-06-19 14:14:50 PDT

Comment on attachment 402316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402316&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:242 > + "name": "Apple AppleTV 13 Release (Build)", "type": "Build", "builddir": "appletv-13-release", Let’s avoid space and symbols in builder name, so that it helps when we upgrade to new buildbot version. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:247 > + "name": "Apple AppleTV Simulator 13 Release (Build)", "type": "Build", "builddir": "appletv-simulator-13-release", Apple AppleTV seems weird. Maybe we should replace AppleTV with tvOS everywhere in this patch.

Ryan Haddad

Comment 4 2020-06-19 14:20:00 PDT

(In reply to Aakash Jain from comment #3) > Comment on attachment 402316 [details] > Apple AppleTV seems weird. Maybe we should replace AppleTV with tvOS > everywhere in this patch. +1 on this suggestion.

Jonathan Bedard

Comment 5 2020-06-19 14:31:38 PDT

(In reply to Aakash Jain from comment #3) > Comment on attachment 402316 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402316&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:242 > > + "name": "Apple AppleTV 13 Release (Build)", "type": "Build", "builddir": "appletv-13-release", > > Let’s avoid space and symbols in builder name, so that it helps when we > upgrade to new buildbot version. > > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:247 > > + "name": "Apple AppleTV Simulator 13 Release (Build)", "type": "Build", "builddir": "appletv-simulator-13-release", > > Apple AppleTV seems weird. Maybe we should replace AppleTV with tvOS > everywhere in this patch. And actually, to that point, it's actually --tvos-*** when building anyways.

Jonathan Bedard

Comment 6 2020-06-19 14:45:38 PDT

Created attachment 402328 [details] Patch

Jonathan Bedard

Comment 7 2020-06-19 15:23:24 PDT

Comment on attachment 402328 [details] Patch Landed: <https://trac.webkit.org/changeset/263291/webkit>

Jonathan Bedard

Comment 8 2020-06-19 17:07:50 PDT

Committed r263300: <https://trac.webkit.org/changeset/263300>

Jonathan Bedard

Comment 9 2020-06-19 19:18:57 PDT

watchOS builds are still broken, there is another change incoming.

Jonathan Bedard

Comment 10 2020-06-19 19:37:05 PDT

Committed r263310: <https://trac.webkit.org/changeset/263310>

Alexey Proskuryakov

Comment 11 2020-06-20 11:17:36 PDT

- "Apple-watchOS-6-Release-Build": {platform: Dashboard.Platform.watchOS6Device, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit}, + "Apple-watchOS-6-Release-Build": {platform: Dashboard.Platform.watchOS6Device, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit}, I think that we want to show arm64_32 as 64-bit, first because it really is 64-bit at architecture level, and also to avoid confusion with armv7k. Thoughts?

Jonathan Bedard

Comment 12 2020-06-20 14:42:39 PDT

Reopening to attach new patch.

Jonathan Bedard

Comment 13 2020-06-20 14:42:40 PDT

Created attachment 402404 [details] Patch

EWS

Comment 14 2020-06-20 16:16:09 PDT

Committed r263319: <https://trac.webkit.org/changeset/263319> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402404 [details].

Jonathan Bedard

Comment 15 2020-06-22 06:59:36 PDT

(In reply to Alexey Proskuryakov from comment #11) > - "Apple-watchOS-6-Release-Build": {platform: > Dashboard.Platform.watchOS6Device, debug: false, builder: true, > architecture: Buildbot.BuildArchitecture.SixtyFourBit}, > + "Apple-watchOS-6-Release-Build": {platform: > Dashboard.Platform.watchOS6Device, debug: false, builder: true, > architecture: Buildbot.BuildArchitecture.ThirtyTwoBit}, > > I think that we want to show arm64_32 as 64-bit, first because it really is > 64-bit at architecture level, and also to avoid confusion with armv7k. > Thoughts? I'm fine with switching this back to 64 bit. I went back and forth with it. When I hear '64 bit arm' I think 'arm64' and 'arm64e'

Alexey Proskuryakov

Comment 16 2020-06-22 09:12:54 PDT

Looks like no one disagreed, so please change that back.

Jonathan Bedard

Comment 17 2020-06-22 11:13:59 PDT

Reopening to attach new patch.

Jonathan Bedard

Comment 18 2020-06-22 11:14:00 PDT

Created attachment 402487 [details] Patch

EWS

Comment 19 2020-06-22 11:58:26 PDT

Committed r263358: <https://trac.webkit.org/changeset/263358> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402487 [details].

Note You need to log in before you can comment on or make changes to this bug.