Bug 213400

Summary: Use ASCIILiteral more for SandboxExtension functions
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, pvollan, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-06-19 12:52:46 PDT
Use ASCIILiteral more for SandboxExtension functions. Functions like createHandleForMachLookup() / createHandleForIOKitClassExtension() don't need to take in Strings, ASCIILiteral is enough.
Attachments
Patch (29.19 KB, patch)
2020-06-19 12:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (30.02 KB, patch)
2020-06-19 13:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (31.50 KB, patch)
2020-06-19 13:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (32.05 KB, patch)
2020-06-19 13:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-06-19 12:59:52 PDT
Created attachment 402310 [details] Patch
Chris Dumez
Comment 2 2020-06-19 13:07:27 PDT
Created attachment 402311 [details] Patch
Chris Dumez
Comment 3 2020-06-19 13:11:04 PDT
Created attachment 402312 [details] Patch
Chris Dumez
Comment 4 2020-06-19 13:55:46 PDT
Created attachment 402321 [details] Patch
Per Arne Vollan
Comment 5 2020-06-19 14:03:26 PDT
Comment on attachment 402321 [details] Patch R=me.
EWS
Comment 6 2020-06-19 14:31:59 PDT
Committed r263288: <https://trac.webkit.org/changeset/263288> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402321 [details].
Radar WebKit Bug Importer
Comment 7 2020-06-19 14:32:17 PDT
<rdar://problem/64545289>
Note You need to log in before you can comment on or make changes to this bug.