Bug 213400 - Use ASCIILiteral more for SandboxExtension functions
Summary: Use ASCIILiteral more for SandboxExtension functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-19 12:52 PDT by Chris Dumez
Modified: 2020-06-19 14:32 PDT (History)
11 users (show)

See Also:


Attachments
Patch (29.19 KB, patch)
2020-06-19 12:59 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (30.02 KB, patch)
2020-06-19 13:07 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (31.50 KB, patch)
2020-06-19 13:11 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (32.05 KB, patch)
2020-06-19 13:55 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-06-19 12:52:46 PDT
Use ASCIILiteral more for SandboxExtension functions. Functions like createHandleForMachLookup() / createHandleForIOKitClassExtension() don't need to take in Strings, ASCIILiteral is enough.
Comment 1 Chris Dumez 2020-06-19 12:59:52 PDT
Created attachment 402310 [details]
Patch
Comment 2 Chris Dumez 2020-06-19 13:07:27 PDT
Created attachment 402311 [details]
Patch
Comment 3 Chris Dumez 2020-06-19 13:11:04 PDT
Created attachment 402312 [details]
Patch
Comment 4 Chris Dumez 2020-06-19 13:55:46 PDT
Created attachment 402321 [details]
Patch
Comment 5 Per Arne Vollan 2020-06-19 14:03:26 PDT
Comment on attachment 402321 [details]
Patch

R=me.
Comment 6 EWS 2020-06-19 14:31:59 PDT
Committed r263288: <https://trac.webkit.org/changeset/263288>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402321 [details].
Comment 7 Radar WebKit Bug Importer 2020-06-19 14:32:17 PDT
<rdar://problem/64545289>