Bug 213399

Summary: [WPE][GTK] Add autocleanup for WebKitWebsitePolicies
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, cturner, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2020-06-19 12:38:08 PDT
We forgot to add an autocleanup for WebKitWebsitePolicies. If we were to switch to G_DECLARE_[FINAL,DERIVABLE]_TYPE for the GTK 4 API, then we wouldn't have to remember to do these manually anymore. ;)
Attachments
Patch (2.42 KB, patch)
2020-06-19 12:39 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2020-06-19 12:39:27 PDT
Created attachment 402306 [details] Patch
EWS Watchlist
Comment 2 2020-06-19 12:40:05 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Charlie Turner
Comment 3 2020-06-19 13:17:13 PDT
LGTM (not a formal reviewer sadly). Thanks for taking care of it!
Carlos Garcia Campos
Comment 4 2020-06-21 02:08:23 PDT
Comment on attachment 402306 [details] Patch I always forget autoclean. Thanks!
EWS
Comment 5 2020-06-21 02:11:08 PDT
Committed r263325: <https://trac.webkit.org/changeset/263325> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402306 [details].
Note You need to log in before you can comment on or make changes to this bug.