Bug 213396

Summary: [iOS] RenderThemeIOS::cssValueToSystemColorMap() does an unnecessary linear search under systemColorFromCSSValueID()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, ggaren, glenn, kondapallykalyan, pdr, pvollan, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204314
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-06-19 11:52:11 PDT
RenderThemeIOS::cssValueToSystemColorMap() does an unnecessary linear search under systemColorFromCSSValueID(). cssValueToSystemColorMap() already has the selector, yet it passes a CSSValueID to systemColorFromCSSValueID() which then does a linear search to match the CSSValueID to a selector.
Attachments
Patch (3.65 KB, patch)
2020-06-19 12:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.81 KB, patch)
2020-06-19 12:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-06-19 12:09:37 PDT
Created attachment 402303 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-06-19 12:11:12 PDT
<rdar://problem/64540057>
Chris Dumez
Comment 3 2020-06-19 12:17:26 PDT
Created attachment 402304 [details] Patch
EWS
Comment 4 2020-06-19 13:13:19 PDT
Committed r263282: <https://trac.webkit.org/changeset/263282> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402304 [details].
Note You need to log in before you can comment on or make changes to this bug.