Bug 213395

Summary: Make $vm properties non-configurable, non-enumerable, and non-writable.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
saam: review+
patch for landing. none

Mark Lam
Reported 2020-06-19 11:41:12 PDT
...
Attachments
proposed patch. (4.41 KB, patch)
2020-06-19 11:43 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
patch for landing. (6.61 KB, patch)
2020-06-19 13:55 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-06-19 11:43:30 PDT
Created attachment 402300 [details] proposed patch.
Saam Barati
Comment 2 2020-06-19 11:59:17 PDT
Comment on attachment 402300 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=402300&action=review > Source/JavaScriptCore/ChangeLog:3 > + Make $vm properties non-configurable, non-enumerable, and non-writable. say why
Yusuke Suzuki
Comment 3 2020-06-19 12:01:49 PDT
Comment on attachment 402300 [details] proposed patch. r=me. Can we have a test that ensures Object.keys for $vm does not contain interesting keys?
Mark Lam
Comment 4 2020-06-19 13:55:12 PDT
Created attachment 402320 [details] patch for landing.
Mark Lam
Comment 5 2020-06-19 14:01:05 PDT
Thanks for the reviews. Landed in r263283: <http://trac.webkit.org/r263283>.
Radar WebKit Bug Importer
Comment 6 2020-06-19 14:02:17 PDT
<rdar://problem/64544350>
Radar WebKit Bug Importer
Comment 7 2020-06-19 14:02:17 PDT
<rdar://problem/64544351>
Mark Lam
Comment 8 2020-06-23 11:09:26 PDT
<rdar://problem/64544350>
Keith Miller
Comment 9 2020-06-23 12:00:26 PDT
Why don't we just freeze $vm?
Note You need to log in before you can comment on or make changes to this bug.