Bug 213346

Summary: Workaround for UIKit layout bug in time picker.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Megan Gardner 2020-06-18 11:48:27 PDT
Workaround for UIKit layout bug in time picker.
Comment 1 Megan Gardner 2020-06-18 11:57:12 PDT
Created attachment 402222 [details]
Patch
Comment 2 Tim Horton 2020-06-18 12:06:08 PDT
Comment on attachment 402222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402222&action=review

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:82
> +    // FIXME: Workaround, should be able to be readresses after <rdar://problem/64143534>

"readdresses" -> readdressed?

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:88
> +        view.layoutMargins = (UIEdgeInsets) {16, 16, 16, 16};

We usually use UIEdgeInsetsMake
Comment 3 Megan Gardner 2020-06-18 14:35:52 PDT
Created attachment 402237 [details]
Patch for landing
Comment 4 Megan Gardner 2020-06-18 14:36:23 PDT
<rdar://problem/64042277>
Comment 5 EWS 2020-06-18 15:16:30 PDT
Committed r263232: <https://trac.webkit.org/changeset/263232>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402237 [details].