Bug 213346

Summary: Workaround for UIKit layout bug in time picker.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Megan Gardner
Reported 2020-06-18 11:48:27 PDT
Workaround for UIKit layout bug in time picker.
Attachments
Patch (2.04 KB, patch)
2020-06-18 11:57 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.04 KB, patch)
2020-06-18 14:35 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-06-18 11:57:12 PDT
Created attachment 402222 [details] Patch
Tim Horton
Comment 2 2020-06-18 12:06:08 PDT
Comment on attachment 402222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402222&action=review > Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:82 > + // FIXME: Workaround, should be able to be readresses after <rdar://problem/64143534> "readdresses" -> readdressed? > Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:88 > + view.layoutMargins = (UIEdgeInsets) {16, 16, 16, 16}; We usually use UIEdgeInsetsMake
Megan Gardner
Comment 3 2020-06-18 14:35:52 PDT
Created attachment 402237 [details] Patch for landing
Megan Gardner
Comment 4 2020-06-18 14:36:23 PDT
<rdar://problem/64042277>
EWS
Comment 5 2020-06-18 15:16:30 PDT
Committed r263232: <https://trac.webkit.org/changeset/263232> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402237 [details].
Note You need to log in before you can comment on or make changes to this bug.