Bug 213330

Summary: [WinCairo][MediaFoundation] Use /DELAYLOAD for mf.dll
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: PlatformAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, don.olmstead, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, pvollan, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pvollan: review+

Fujii Hironori
Reported 2020-06-17 22:23:49 PDT
[WinCairo][MediaFoundation] Use /DELAYLOAD for mf.dll In Bug 198783, I stopped using soft linking for Media Foundation. A Playwright user is using Windows 10 N which doesn't have Media Foundation. https://github.com/microsoft/playwright/issues/2548#issuecomment-645700214 I should try /DELAYLOAD for mf.dll as Chromium does. https://chromium.googlesource.com/chromium/src/+/HEAD/media/gpu/BUILD.gn#238
Attachments
Patch (2.50 KB, patch)
2020-07-08 20:06 PDT, Fujii Hironori 		pvollan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-07-08 20:06:40 PDT
Created attachment 403838 [details] Patch
Per Arne Vollan
Comment 2 2020-07-09 07:42:04 PDT
Comment on attachment 403838 [details] Patch R=me.
Fujii Hironori
Comment 3 2020-07-09 12:50:07 PDT
Committed r264188: <https://trac.webkit.org/changeset/264188>
Radar WebKit Bug Importer
Comment 4 2020-07-09 12:51:14 PDT
<rdar://problem/65285274>
Fujii Hironori
Comment 5 2020-07-09 18:15:38 PDT
Oops. This change intoduced linker warnings for WinCairo. Filed: Bug 214170 – [WinCairo][MediaFoundation] r264188 introduced linker warning: LNK4199: /DELAYLOAD:mf.dll ignored; no imports found from mf.dll
Fujii Hironori
Comment 6 2020-09-11 15:25:26 PDT
Oops. there is one more dll. Filed: Bug 216420 – [WinCairo][MediaFoundation] Use /DELAYLOAD for evr.dll
Note You need to log in before you can comment on or make changes to this bug.