Bug 213330 - [WinCairo][MediaFoundation] Use /DELAYLOAD for mf.dll
Summary: [WinCairo][MediaFoundation] Use /DELAYLOAD for mf.dll
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-17 22:23 PDT by Fujii Hironori
Modified: 2020-09-11 15:25 PDT (History)
15 users (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2020-07-08 20:06 PDT, Fujii Hironori
pvollan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-06-17 22:23:49 PDT
[WinCairo][MediaFoundation] Use /DELAYLOAD for mf.dll

In Bug 198783, I stopped using soft linking for Media Foundation.

A Playwright user is using Windows 10 N which doesn't have Media Foundation.
https://github.com/microsoft/playwright/issues/2548#issuecomment-645700214

I should try /DELAYLOAD for mf.dll as Chromium does.
https://chromium.googlesource.com/chromium/src/+/HEAD/media/gpu/BUILD.gn#238
Comment 1 Fujii Hironori 2020-07-08 20:06:40 PDT
Created attachment 403838 [details]
Patch
Comment 2 Per Arne Vollan 2020-07-09 07:42:04 PDT
Comment on attachment 403838 [details]
Patch

R=me.
Comment 3 Fujii Hironori 2020-07-09 12:50:07 PDT
Committed r264188: <https://trac.webkit.org/changeset/264188>
Comment 4 Radar WebKit Bug Importer 2020-07-09 12:51:14 PDT
<rdar://problem/65285274>
Comment 5 Fujii Hironori 2020-07-09 18:15:38 PDT
Oops. This change intoduced linker warnings for WinCairo.
Filed: Bug 214170 – [WinCairo][MediaFoundation] r264188 introduced linker warning: LNK4199: /DELAYLOAD:mf.dll ignored; no imports found from mf.dll
Comment 6 Fujii Hironori 2020-09-11 15:25:26 PDT
Oops. there is one more dll.
Filed: Bug 216420 – [WinCairo][MediaFoundation] Use /DELAYLOAD for evr.dll