Bug 213320

Summary: [macOS] Shift-tab in a bullet list in Mail Compose jumps back to Subject field
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, darin, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For EWS none

Wenson Hsieh
Reported 2020-06-17 16:17:40 PDT
<rdar://problem/63831962>
Attachments
Patch (11.45 KB, patch)
2020-06-17 16:40 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
For EWS (11.50 KB, patch)
2020-06-17 17:34 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-06-17 16:40:14 PDT
Created attachment 402167 [details] Patch
Tim Horton
Comment 2 2020-06-17 16:46:24 PDT
Comment on attachment 402167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:2848 > + if (event.charCode() != 9) Even '\t' might be preferable to this MAGICAL 9.
Wenson Hsieh
Comment 3 2020-06-17 16:47:44 PDT
(In reply to Tim Horton from comment #2) > Comment on attachment 402167 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402167&action=review > > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:2848 > > + if (event.charCode() != 9) > > Even '\t' might be preferable to this MAGICAL 9. Good call!
Darin Adler
Comment 4 2020-06-17 17:24:27 PDT
Comment on attachment 402167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:2852 > + if (!event.shiftKey()) > + return false; What about other modifiers like control, option, and command?
Wenson Hsieh
Comment 5 2020-06-17 17:30:04 PDT
Comment on attachment 402167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review >> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2852 >> + return false; > > What about other modifiers like control, option, and command? Oops, that's right — we probably ought to avoid relinquishing focus if any of the other modifier keys are set.
Darin Adler
Comment 6 2020-06-17 17:31:30 PDT
But maybe not caps lock. This keyboard mapping to commands business is rough.
Wenson Hsieh
Comment 7 2020-06-17 17:34:07 PDT
Created attachment 402170 [details] For EWS
Wenson Hsieh
Comment 8 2020-06-17 19:26:56 PDT
Committed r263196: <https://trac.webkit.org/changeset/263196>
Note You need to log in before you can comment on or make changes to this bug.