Summary: | [macOS] Shift-tab in a bullet list in Mail Compose jumps back to Subject field | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, darin, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2020-06-17 16:17:40 PDT
Created attachment 402167 [details]
Patch
Comment on attachment 402167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:2848 > + if (event.charCode() != 9) Even '\t' might be preferable to this MAGICAL 9. (In reply to Tim Horton from comment #2) > Comment on attachment 402167 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402167&action=review > > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:2848 > > + if (event.charCode() != 9) > > Even '\t' might be preferable to this MAGICAL 9. Good call! Comment on attachment 402167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:2852 > + if (!event.shiftKey()) > + return false; What about other modifiers like control, option, and command? Comment on attachment 402167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review >> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2852 >> + return false; > > What about other modifiers like control, option, and command? Oops, that's right — we probably ought to avoid relinquishing focus if any of the other modifier keys are set. But maybe not caps lock. This keyboard mapping to commands business is rough. Created attachment 402170 [details]
For EWS
Committed r263196: <https://trac.webkit.org/changeset/263196> |