Bug 213320

Summary: [macOS] Shift-tab in a bullet list in Mail Compose jumps back to Subject field
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, darin, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For EWS none

Description Wenson Hsieh 2020-06-17 16:17:40 PDT
<rdar://problem/63831962>
Comment 1 Wenson Hsieh 2020-06-17 16:40:14 PDT
Created attachment 402167 [details]
Patch
Comment 2 Tim Horton 2020-06-17 16:46:24 PDT
Comment on attachment 402167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2848
> +    if (event.charCode() != 9)

Even '\t' might be preferable to this MAGICAL 9.
Comment 3 Wenson Hsieh 2020-06-17 16:47:44 PDT
(In reply to Tim Horton from comment #2)
> Comment on attachment 402167 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402167&action=review
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:2848
> > +    if (event.charCode() != 9)
> 
> Even '\t' might be preferable to this MAGICAL 9.

Good call!
Comment 4 Darin Adler 2020-06-17 17:24:27 PDT
Comment on attachment 402167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2852
> +    if (!event.shiftKey())
> +        return false;

What about other modifiers like control, option, and command?
Comment 5 Wenson Hsieh 2020-06-17 17:30:04 PDT
Comment on attachment 402167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review

>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2852
>> +        return false;
> 
> What about other modifiers like control, option, and command?

Oops, that's right — we probably ought to avoid relinquishing focus if any of the other modifier keys are set.
Comment 6 Darin Adler 2020-06-17 17:31:30 PDT
But maybe not caps lock. This keyboard mapping to commands business is rough.
Comment 7 Wenson Hsieh 2020-06-17 17:34:07 PDT
Created attachment 402170 [details]
For EWS
Comment 8 Wenson Hsieh 2020-06-17 19:26:56 PDT
Committed r263196: <https://trac.webkit.org/changeset/263196>