Bug 213305

Summary: Null check plugin.m_data before using it in PDFPlugin::ByteRangeRequest::completeUnconditionally
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2020-06-17 10:33:47 PDT
Null check plugin.m_data before using it in PDFPlugin::ByteRangeRequest::completeUnconditionally
Attachments
Patch (1.53 KB, patch)
2020-06-17 10:34 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-06-17 10:34:44 PDT
Created attachment 402130 [details] Patch
Alexey Proskuryakov
Comment 2 2020-06-17 10:43:43 PDT
Comment on attachment 402130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402130&action=review > Source/WebKit/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). No test?
Alex Christensen
Comment 3 2020-06-17 10:47:05 PDT
Comment on attachment 402130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402130&action=review >> Source/WebKit/ChangeLog:7 >> + Reviewed by NOBODY (OOPS!). > > No test? No test. I believe our crash logs justify this change, and Brady's comment in radar convinces me that this is an edge case happening during teardown.
Brady Eidson
Comment 4 2020-06-17 11:02:18 PDT
Comment on attachment 402130 [details] Patch No test in deed - one of those cases where it's obvious what's happening but not feasible to get it happening reliably for testing.
EWS
Comment 5 2020-06-17 11:16:25 PDT
Committed r263169: <https://trac.webkit.org/changeset/263169> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402130 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-17 11:17:19 PDT
<rdar://problem/64455684>
Note You need to log in before you can comment on or make changes to this bug.