Bug 213304

Summary: $vm.haveABadTime/isHavingABadTime should work with non-globalObject parameters
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
ews-feeder: commit-queue-
Patch for landing
none
Patch for landing none

Keith Miller
Reported 2020-06-17 10:22:35 PDT
$vm.haveABadTime/isHavingABadTime should work with non-globalObject parameters
Attachments
Patch (4.25 KB, patch)
2020-06-17 10:22 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (4.76 KB, patch)
2020-06-17 10:27 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (5.26 KB, patch)
2020-06-17 10:32 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.25 KB, patch)
2020-06-17 10:39 PDT, Keith Miller 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (5.36 KB, patch)
2020-06-17 10:42 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.51 KB, patch)
2020-06-17 10:55 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-06-17 10:22:57 PDT
Created attachment 402125 [details] Patch
Keith Miller
Comment 2 2020-06-17 10:27:08 PDT
Created attachment 402127 [details] Patch
Mark Lam
Comment 3 2020-06-17 10:29:27 PDT
Comment on attachment 402127 [details] Patch r=me
Keith Miller
Comment 4 2020-06-17 10:32:58 PDT
Created attachment 402128 [details] Patch
Keith Miller
Comment 5 2020-06-17 10:39:54 PDT
Created attachment 402131 [details] Patch for landing
Keith Miller
Comment 6 2020-06-17 10:42:40 PDT
Created attachment 402132 [details] Patch for landing
Keith Miller
Comment 7 2020-06-17 10:55:34 PDT
Created attachment 402133 [details] Patch for landing
Saam Barati
Comment 8 2020-06-17 11:05:44 PDT
Comment on attachment 402133 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=402133&action=review > Source/JavaScriptCore/ChangeLog:13 > + the first parameter even if it's not a JSGlobalObject. If no I feel like we should rename this then to express what new semantics are?
Keith Miller
Comment 9 2020-06-17 11:08:03 PDT
Comment on attachment 402133 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=402133&action=review >> Source/JavaScriptCore/ChangeLog:13 >> + the first parameter even if it's not a JSGlobalObject. If no > > I feel like we should rename this then to express what new semantics are? I kinda think, with this change, the no parameter case is the primary case. In that world the current name makes sense, IMO. The first parameter is just for convenience.
EWS
Comment 10 2020-06-17 11:10:23 PDT
Patch 402131 does not build
EWS
Comment 11 2020-06-17 11:40:20 PDT
Committed r263174: <https://trac.webkit.org/changeset/263174> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402133 [details].
Radar WebKit Bug Importer
Comment 12 2020-06-17 11:41:24 PDT
<rdar://problem/64456665>
Note You need to log in before you can comment on or make changes to this bug.