Summary: | $vm.haveABadTime/isHavingABadTime should work with non-globalObject parameters | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||||||||
Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Keith Miller
2020-06-17 10:22:35 PDT
Created attachment 402125 [details]
Patch
Created attachment 402127 [details]
Patch
Comment on attachment 402127 [details]
Patch
r=me
Created attachment 402128 [details]
Patch
Created attachment 402131 [details]
Patch for landing
Created attachment 402132 [details]
Patch for landing
Created attachment 402133 [details]
Patch for landing
Comment on attachment 402133 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=402133&action=review > Source/JavaScriptCore/ChangeLog:13 > + the first parameter even if it's not a JSGlobalObject. If no I feel like we should rename this then to express what new semantics are? Comment on attachment 402133 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=402133&action=review >> Source/JavaScriptCore/ChangeLog:13 >> + the first parameter even if it's not a JSGlobalObject. If no > > I feel like we should rename this then to express what new semantics are? I kinda think, with this change, the no parameter case is the primary case. In that world the current name makes sense, IMO. The first parameter is just for convenience. Patch 402131 does not build Committed r263174: <https://trac.webkit.org/changeset/263174> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402133 [details]. |