| Summary: | Added missing orientation attributes to PannerNode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Clark Wang <clark_wang> | ||||
| Component: | Web Audio | Assignee: | Clark Wang <clark_wang> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Minor | CC: | cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 212611 | ||||||
| Attachments: |
|
||||||
|
Description
Clark Wang
2020-06-17 09:18:46 PDT
Created attachment 402118 [details]
Patch
Comment on attachment 402118 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402118&action=review r=me. Patch looks good but let's hold off on committing until the feature flag is added. > Source/WebCore/Modules/webaudio/PannerNode.cpp:79 > + // FIXME: Remove velocity from PannerNode Once the feature flag is added in https://bugs.webkit.org/show_bug.cgi?id=213268, you will be able to drop velocity. Comment on attachment 402118 [details] Patch Clearing flags on attachment: 402118 Committed r263199: <https://trac.webkit.org/changeset/263199> All reviewed patches have been landed. Closing bug. |