Bug 213301 - Added missing orientation attributes to PannerNode
Summary: Added missing orientation attributes to PannerNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Clark Wang
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency treegraph
 
Reported: 2020-06-17 09:18 PDT by Clark Wang
Modified: 2020-06-17 21:17 PDT (History)
10 users (show)

See Also:


Attachments
Patch (10.35 KB, patch)
2020-06-17 09:30 PDT, Clark Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Clark Wang 2020-06-17 09:18:46 PDT
Added orientationX, orientationY, orientationZ to PannerNode. Set FIXMEs for removing velocity in PannerNode.
Comment 1 Clark Wang 2020-06-17 09:30:05 PDT
Created attachment 402118 [details]
Patch
Comment 2 Chris Dumez 2020-06-17 09:43:40 PDT
Comment on attachment 402118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402118&action=review

r=me. Patch looks good but let's hold off on committing until the feature flag is added.

> Source/WebCore/Modules/webaudio/PannerNode.cpp:79
> +    // FIXME: Remove velocity from PannerNode

Once the feature flag is added in https://bugs.webkit.org/show_bug.cgi?id=213268, you will be able to drop velocity.
Comment 3 Chris Dumez 2020-06-17 21:16:50 PDT
Comment on attachment 402118 [details]
Patch

Clearing flags on attachment: 402118

Committed r263199: <https://trac.webkit.org/changeset/263199>
Comment 4 Chris Dumez 2020-06-17 21:16:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-06-17 21:17:18 PDT
<rdar://problem/64475729>