Bug 213286

Summary: Enable stale-while-revalidate support by default
Product: WebKit Reporter: Rob Buis <rbuis>
Component: WebCore Misc.Assignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2020-06-17 01:14:27 PDT
Enable stale-while-revalidate support by default by removing the build flag.
Attachments
Patch (55.95 KB, patch)
2020-06-17 01:52 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (1.62 KB, patch)
2020-06-17 04:21 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-06-17 01:52:33 PDT
Created attachment 402093 [details] Patch
youenn fablet
Comment 2 2020-06-17 02:48:18 PDT
This seems ok to remove the build flag. Should we also contemplate changing WebsiteDataStoreConfiguration::m_networkCacheSpeculativeValidationEnabled value, or in a separate patch maybe?
Rob Buis
Comment 3 2020-06-17 04:21:39 PDT
Created attachment 402098 [details] Patch
Rob Buis
Comment 4 2020-06-17 06:10:32 PDT
I think this may be the best way to do it. Just removing the build flag will fail for platforms not building with speculative load. And just replacing the s-w-r build flag with speculative load build flag would probably be confusing.
EWS
Comment 5 2020-06-19 09:18:48 PDT
Committed r263269: <https://trac.webkit.org/changeset/263269> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402098 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-19 09:19:17 PDT
<rdar://problem/64533689>
Note You need to log in before you can comment on or make changes to this bug.