Bug 213274

Summary:

update-webkit-localizable-strings exits without writing localized strings because of an R"" string

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

New Bugs

Assignee:

Kate Cheney <katherine_cheney>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, darin, katherine_cheney, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Said Abou-Hallawa

Reported 2020-06-16 17:04:01 PDT

When adding new localized strings in WebKit and running update-webkit-localizable-strings, I get the following errors: Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:929: mismatched quotes Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:946: mismatched quotes 577 localizable strings 41665 strings not marked for localization Errors encountered. Exiting without writing to Source/WebCore/en.lproj/Localizable.strings. When commenting the R"" string in joinSubStatisticsForSorting() and rerunning the tool, the localized strings are generated as expected.

Attachments
Patch (3.56 KB, patch) 2020-07-06 11:49 PDT, Kate Cheney	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-06-16 17:04:37 PDT

<rdar://problem/64427891>

Andy Estes

Comment 2 2020-06-16 17:06:47 PDT

*** Bug 213273 has been marked as a duplicate of this bug. ***

Kate Cheney

Comment 3 2020-07-06 11:49:33 PDT

Created attachment 403602 [details] Patch

EWS

Comment 4 2020-07-06 13:19:55 PDT

Committed r263982: <https://trac.webkit.org/changeset/263982> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403602 [details].

Note You need to log in before you can comment on or make changes to this bug.