Bug 213263

Summary: [WebDriver][WPE] Update imported selenium to a version with the WPE WebDriver
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: WebDriverAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cgarcia, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Lauro Moura
Reported 2020-06-16 15:02:44 PDT
The currently imported version of Selenium (300cd3fa0288d3a88eb4b4c459c54bd02a015118 - March 2018) does not have the WPE WebDriver module (merged in 0d7e57a7079c0a48286e8e741a0122916c08ca16 - Mar 2020).
Attachments
Patch (41.77 KB, patch)
2020-06-16 18:11 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Patch (218.94 KB, patch)
2020-06-18 20:18 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-06-16 18:11:08 PDT
Created attachment 402062 [details] Patch
Carlos Garcia Campos
Comment 2 2020-06-17 00:35:17 PDT
Comment on attachment 402062 [details] Patch Is this really including all the changes? I think the are more changes in tests and other files I don't see here
Lauro Moura
Comment 3 2020-06-18 20:16:07 PDT
(In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 402062 [details] > Patch > > Is this really including all the changes? I think the are more changes in > tests and other files I don't see here Indeed a bunch of changes were missing. I'm finishing some tests to update the patch. Thanks.
Lauro Moura
Comment 4 2020-06-18 20:18:35 PDT
Created attachment 402264 [details] Patch
EWS
Comment 5 2020-06-19 06:53:05 PDT
Committed r263264: <https://trac.webkit.org/changeset/263264> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402264 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-19 06:54:18 PDT
<rdar://problem/64530313>
Note You need to log in before you can comment on or make changes to this bug.