Summary: | Check for inAppBrowserPrivacyEnabled flag in WebsiteDataStore::initializeAppBoundDomains is expensive and calls a non-static function WebsiteDataStore::parameters(). | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||
Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, mjs, webkit-bug-importer, wilander | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kate Cheney
2020-06-16 14:34:11 PDT
Created attachment 402043 [details]
Patch
Comment on attachment 402043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402043&action=review > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:455 > + RunLoop::main().dispatch([this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] () mutable { I think we could just WTFMove(protectedThis). Created attachment 402047 [details]
Patch for landing
(In reply to Brent Fulgham from comment #3) > Comment on attachment 402043 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402043&action=review > > > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:455 > > + RunLoop::main().dispatch([this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] () mutable { > > I think we could just WTFMove(protectedThis). Good call, thanks for the review! Committed r263122: <https://trac.webkit.org/changeset/263122> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402047 [details]. |