Bug 21323

Summary: run-webkit-tests with --pixel and --reset hangs
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch, changelog darin: review+

Simon Fraser (smfr)
Reported 2008-10-02 17:18:11 PDT
The tests hang if called with both --pixel and --reset. The problem is that DRT and the script disagree on when the PNG dump is going to happen, so the scripts ends up treating a PNG dump as if it were text output. This regressed in bug 21124.
Attachments
Patch, changelog (1.69 KB, patch)
2008-10-02 17:20 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2008-10-02 17:20:38 PDT
Created attachment 24038 [details] Patch, changelog
Darin Adler
Comment 2 2008-10-03 17:12:31 PDT
Comment on attachment 24038 [details] Patch, changelog r=me
Simon Fraser (smfr)
Comment 3 2008-10-03 17:17:10 PDT
M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r37269 = f415948b7306d75e3ffe5fcaaa0a86f040eef251 (trunk)
Note You need to log in before you can comment on or make changes to this bug.