Bug 213219

Summary: Multiple hypothesis testing should use False Discovery Rate instead of Bonferroni
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2020-06-15 15:07:16 PDT
...
Attachments
patch (6.90 KB, patch)
2020-06-15 17:53 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-06-15 17:53:50 PDT
Created attachment 401961 [details] patch
Mark Lam
Comment 2 2020-06-16 13:49:16 PDT
Comment on attachment 401961 [details] patch r=me
EWS
Comment 3 2020-06-16 14:09:33 PDT
Committed r263114: <https://trac.webkit.org/changeset/263114> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401961 [details].
Radar WebKit Bug Importer
Comment 4 2020-06-16 14:10:25 PDT
<rdar://problem/64421181>
Darin Adler
Comment 5 2020-06-16 15:58:07 PDT
Comment on attachment 401961 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401961&action=review > Tools/Scripts/compare-results:181 > + isSignifcant = computeMultipleHypothesesSignficance(a, b) typo: "signifcant"
Saam Barati
Comment 6 2020-06-16 16:22:38 PDT
(In reply to Darin Adler from comment #5) > Comment on attachment 401961 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401961&action=review > > > Tools/Scripts/compare-results:181 > > + isSignifcant = computeMultipleHypothesesSignficance(a, b) > > typo: "signifcant" Ah, I typod it twice! "Signficance" too Will fix
Saam Barati
Comment 7 2020-06-16 16:29:41 PDT
fixed in: https://trac.webkit.org/changeset/263124/webkit
Note You need to log in before you can comment on or make changes to this bug.