Bug 21320

Summary: leaks of PropertyNameArrayData seen on buildbot
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 21513    
Attachments:
Description Flags
patch oliver: review+

Description Geoffrey Garen 2008-10-02 16:09:10 PDT 
StructureID holds a RefPtr to PropertyNameArrayData, and vice-versa. That's the leak.

Sam mentioned that PropertyNameArrayData's pointer could be a weak pointer instead, cleared in the StructureID destructor.
Comment 1 Sam Weinig 2008-10-04 14:32:18 PDT 
Created attachment 24092 [details]
patch
Comment 2 Oliver Hunt 2008-10-04 14:44:31 PDT 
Comment on attachment 24092 [details]
patch

r=me -- test case?
Comment 3 Sam Weinig 2008-10-04 14:59:16 PDT 
Fixed in r37300.