Bug 213184

Summary: [LFC][Floats] Remove FloatBox class
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

alan
Reported 2020-06-14 10:27:37 PDT
apparently the only difference between a non-floating float avoider (regular formatting context root) and a float box is that while float boxes intersect their margin box, simple float avoiders use their border box. We can do that without subclassing FloatAvoider.
Attachments
Patch (35.01 KB, patch)
2020-06-14 10:36 PDT, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-06-14 10:36:31 PDT
Created attachment 401863 [details] Patch
Antti Koivisto
Comment 2 2020-06-17 06:56:05 PDT
Comment on attachment 401863 [details] Patch Nice
EWS
Comment 3 2020-06-17 07:05:50 PDT
Committed r263144: <https://trac.webkit.org/changeset/263144> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401863 [details].
Radar WebKit Bug Importer
Comment 4 2020-06-17 07:06:24 PDT
<rdar://problem/64447114>
Note You need to log in before you can comment on or make changes to this bug.