Summary: | REGRESSION(r262994): [GTK] More than 100 tests are failing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||
Component: | New Bugs | Assignee: | Diego Pino <dpino> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ddkilzer, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=206738 | ||||||||
Bug Depends on: | 211988 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Diego Pino
2020-06-13 14:02:30 PDT
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20(Tests)/r263006%20(6439)/fast/loader/javascript-url-in-embed-crash-log.txt STDERR: STDERR: warning: core file may not match specified executable file. STDERR: ASSERTION FAILED: WTF::isValidEnum<E>(WTF::enumToUnderlyingType<E>(enumValue)) STDERR: ../../Source/WebKit/Platform/IPC/Encoder.h(108) : void IPC::Encoder::encode(E) [with E = WebCore::PluginLoadClientPolicy; std::enable_if_t<std::is_enum<_Tp>::value>* <anonymous> = 0] STDERR: 1 0x7f70a743bb63 WTFCrash Sorry, just noticed this. Will look into it tomorrow. (Also forgot that GTK tests aren't run by EWS.) I wonder if we just need to provide a default initializer for WebCore::PluginInfo::clientLoadPolicy (and ::isApplicationPlugin while we're here): diff --git a/Source/WebCore/plugins/PluginData.h b/Source/WebCore/plugins/PluginData.h index 259e3dc847e..1ca828883cc 100644 --- a/Source/WebCore/plugins/PluginData.h +++ b/Source/WebCore/plugins/PluginData.h @@ -67,7 +67,7 @@ struct PluginInfo { Vector<MimeClassInfo> mimes; - bool isApplicationPlugin; + bool isApplicationPlugin { false }; - PluginLoadClientPolicy clientLoadPolicy; + PluginLoadClientPolicy clientLoadPolicy { PluginLoadClientPolicy::Undefined }; String bundleIdentifier; #if PLATFORM(MAC) Created attachment 402085 [details]
Patch
Created attachment 402086 [details]
Patch
Committed r263139: <https://trac.webkit.org/changeset/263139> Thank you David. Your patch fixed the regression (I run the tests locally to verify it). (In reply to Diego Pino from comment #8) > Thank you David. Your patch fixed the regression (I run the tests locally to > verify it). Great! Thanks for testing the fix and committing it. |