Bug 213144

Summary: Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-06-12 13:19:39 PDT
Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
Attachments
Patch (13.81 KB, patch)
2020-06-12 13:29 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (18.04 KB, patch)
2020-06-12 14:58 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (1.21 KB, patch)
2020-06-15 15:29 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-06-12 13:29:39 PDT
Created attachment 401771 [details] Patch
Geoffrey Garen
Comment 2 2020-06-12 13:53:08 PDT
Comment on attachment 401771 [details] Patch r=me
Alex Christensen
Comment 3 2020-06-12 14:53:13 PDT
Looks like MultipleClientCertificateConnections tests also need fixing. That was a real regression that was covered up.
Alex Christensen
Comment 4 2020-06-12 14:58:55 PDT
Created attachment 401789 [details] Patch
Geoffrey Garen
Comment 5 2020-06-12 15:14:34 PDT
Comment on attachment 401789 [details] Patch r=me
EWS
Comment 6 2020-06-12 15:58:06 PDT
Geofferey Garen found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Chris Dumez
Comment 7 2020-06-12 16:01:24 PDT
(In reply to EWS from comment #6) > Geofferey Garen found in > /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to > be a valid reviewer according to contributors.json. That's why I go with "Geoff Garen" in ChangeLogs :P
Alex Christensen
Comment 8 2020-06-12 16:32:29 PDT
http://trac.webkit.org/r262985
Radar WebKit Bug Importer
Comment 9 2020-06-12 16:33:19 PDT
<rdar://problem/64316743>
Jonathan Bedard
Comment 10 2020-06-15 15:29:24 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 11 2020-06-15 15:29:25 PDT
Created attachment 401950 [details] Patch
Alex Christensen
Comment 12 2020-06-15 15:35:12 PDT
https://trac.webkit.org/changeset/263066/webkit
Note You need to log in before you can comment on or make changes to this bug.