Bug 213144

Summary: Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alex Christensen 2020-06-12 13:19:39 PDT
Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
Comment 1 Alex Christensen 2020-06-12 13:29:39 PDT
Created attachment 401771 [details]
Patch
Comment 2 Geoffrey Garen 2020-06-12 13:53:08 PDT
Comment on attachment 401771 [details]
Patch

r=me
Comment 3 Alex Christensen 2020-06-12 14:53:13 PDT
Looks like MultipleClientCertificateConnections tests also need fixing.  That was a real regression that was covered up.
Comment 4 Alex Christensen 2020-06-12 14:58:55 PDT
Created attachment 401789 [details]
Patch
Comment 5 Geoffrey Garen 2020-06-12 15:14:34 PDT
Comment on attachment 401789 [details]
Patch

r=me
Comment 6 EWS 2020-06-12 15:58:06 PDT
Geofferey Garen found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 7 Chris Dumez 2020-06-12 16:01:24 PDT
(In reply to EWS from comment #6)
> Geofferey Garen found in
> /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to
> be a valid reviewer according to contributors.json.

That's why I go with "Geoff Garen" in ChangeLogs :P
Comment 8 Alex Christensen 2020-06-12 16:32:29 PDT
http://trac.webkit.org/r262985
Comment 9 Radar WebKit Bug Importer 2020-06-12 16:33:19 PDT
<rdar://problem/64316743>
Comment 10 Jonathan Bedard 2020-06-15 15:29:24 PDT
Reopening to attach new patch.
Comment 11 Jonathan Bedard 2020-06-15 15:29:25 PDT
Created attachment 401950 [details]
Patch
Comment 12 Alex Christensen 2020-06-15 15:35:12 PDT
https://trac.webkit.org/changeset/263066/webkit