Bug 21313

Summary: wtf/ThreadingWin.cpp expects pthreads
Product: WebKit Reporter: Tony Chang <tony>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
[1/2] Chromium doesn't use pthreads on windows, so make its use conditional.
ap: review+
[2/2] update changelog ap: review+

Description Tony Chang 2008-10-02 12:39:46 PDT
This is causing a problem for Chromium because it doesn't use pthreads.

Patch coming up...
Comment 1 Tony Chang 2008-10-02 12:57:17 PDT
Created attachment 24026 [details]
[1/2] Chromium doesn't use pthreads on windows, so make its use conditional.


Also convert a WORD to a DWORD to avoid a compiler warning.  This
matches the other methods around it.
---
 JavaScriptCore/wtf/ThreadingWin.cpp |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Comment 2 Tony Chang 2008-10-02 12:57:18 PDT
Created attachment 24027 [details]
[2/2] update changelog

 JavaScriptCore/ChangeLog |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
Comment 3 Alexey Proskuryakov 2008-10-02 13:47:44 PDT
Comment on attachment 24026 [details]
[1/2] Chromium doesn't use pthreads on windows, so make its use conditional.

r=me
Comment 4 Alexey Proskuryakov 2008-10-02 13:48:50 PDT
Comment on attachment 24027 [details]
[2/2] update changelog

r=me

In the future, please submit patches as a single file, as this makes both reviewing and landing easier.
Comment 5 Eric Seidel (no email) 2008-10-06 18:22:02 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/ThreadingWin.cpp
Committed r37364