| Summary: | Remove FileError.{h,cpp} after bug 213117 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tetsuharu Ohzeki [UTC+9] <tetsuharu.ohzeki> | ||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, philipj, ryuan.choi, sergio, tommyw, toyoshim, webkit-bug-importer, yutak | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 213117 | ||||||||
| Bug Blocks: | 213168 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tetsuharu Ohzeki [UTC+9]
2020-06-12 02:37:32 PDT
Created attachment 401767 [details]
Patch
Comment on attachment 401767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401767&action=review r=me with nits. > Source/WebCore/fileapi/BlobLoader.h:60 > + Optional<ExceptionCode> m_errorCode { WTF::nullopt }; { WTF::nullopt } is unnecessary. > Source/WebCore/fileapi/FileReaderLoader.cpp:123 > + if (m_errorCode.hasValue()) { .hasValue() should not be necessary. > Source/WebCore/fileapi/FileReaderLoader.cpp:172 > + if (m_errorCode.hasValue()) ditto. > Source/WebCore/fileapi/FileReaderLoader.cpp:232 > + if (m_errorCode.hasValue() && m_errorCode.value() == AbortError) ditto. > Source/WebCore/fileapi/FileReaderLoader.cpp:271 > + if (!m_rawData || m_errorCode.hasValue()) ditto. > Source/WebCore/fileapi/FileReaderLoader.cpp:287 > + if (!m_rawData || m_errorCode.hasValue()) ditto. > Source/WebCore/fileapi/FileReaderLoader.h:121 > + Optional<ExceptionCode> m_errorCode { WTF::nullopt }; { WTF::nullopt } is not needed. > Source/WebCore/fileapi/FileReaderSync.cpp:79 > + if (!error.hasValue()) .hasValue() is not needed. > Source/WebCore/fileapi/NetworkSendQueue.cpp:89 > + if (loader->isLoading() || (errorCode.hasValue() && errorCode.value() == AbortError)) { .hasValue() is not needed. > Source/WebCore/fileapi/NetworkSendQueue.cpp:98 > + ASSERT(errorCode.hasValue()); .hasValue() is not needed. Created attachment 401834 [details]
Patch
Committed r262999: <https://trac.webkit.org/changeset/262999> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401834 [details]. |