Bug 213118

Summary: Add a quirk to allow starting AudioContext if document was interacted
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 260134    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2020-06-12 02:30:58 PDT
Add a quirk to allow starting AudioContext if document was interacted
Attachments
Patch (3.40 KB, patch)
2020-06-12 02:39 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.40 KB, patch)
2020-06-15 01:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-06-12 02:39:14 PDT
Created attachment 401715 [details] Patch
Eric Carlson
Comment 2 2020-06-12 10:22:46 PDT
Comment on attachment 401715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401715&action=review > Source/WebCore/Modules/webaudio/AudioContext.cpp:1089 > +static bool isDocumentAllowingAutoplayWebAudio(const Document& document) Minor nit: "is ... allowing" isn't quite right. Maybe something like "documentAllowsWebAudioToAutoPlay", or "doesDocumentAllowWebAudioToAutoPlay"?
youenn fablet
Comment 3 2020-06-12 13:17:40 PDT
<rdar://problem/64147813>
youenn fablet
Comment 4 2020-06-15 01:30:09 PDT
Created attachment 401887 [details] Patch for landing
EWS
Comment 5 2020-06-15 02:13:13 PDT
Committed r263025: <https://trac.webkit.org/changeset/263025> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401887 [details].
youenn fablet
Comment 6 2020-06-15 02:19:30 PDT
(In reply to Eric Carlson from comment #2) > Comment on attachment 401715 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401715&action=review > > > Source/WebCore/Modules/webaudio/AudioContext.cpp:1089 > > +static bool isDocumentAllowingAutoplayWebAudio(const Document& document) > > Minor nit: "is ... allowing" isn't quite right. Maybe something like > "documentAllowsWebAudioToAutoPlay", or "doesDocumentAllowWebAudioToAutoPlay"? I chose shouldDocumentAllowWebAudioToAutoPlay
Note You need to log in before you can comment on or make changes to this bug.