Bug 213084

Summary: Replace uses of black/white list with block/allow list
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, benjamin, ews-watchlist, fpizlo, ggaren, gskachkov, guijemont, hi, joepeck, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214371
Bug Depends on:    
Bug Blocks: 213092    
Attachments:
Description Flags
patch
keith_miller: review+
patch for landing none

Saam Barati
Reported 2020-06-11 11:05:05 PDT
...
Attachments
patch (35.16 KB, patch)
2020-06-11 11:18 PDT, Saam Barati 		keith_miller: review+
DetailsFormatted DiffDiff
patch for landing (37.79 KB, patch)
2020-06-11 12:31 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-06-11 11:13:32 PDT
Less important than just making the change but exclude/include might fit better too, depending on the context.
Saam Barati
Comment 2 2020-06-11 11:18:19 PDT
Created attachment 401659 [details] patch
Keith Miller
Comment 3 2020-06-11 11:19:01 PDT
Comment on attachment 401659 [details] patch r=me.
EWS Watchlist
Comment 4 2020-06-11 11:19:16 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Mark Lam
Comment 5 2020-06-11 11:23:39 PDT
Comment on attachment 401659 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review > Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:134 > + allowlist = set(ObjCGenerator.DOMAINS_TO_GENERATE) Capitalize the L to be consistent with how we do it elsewhere? > Source/JavaScriptCore/tools/FunctionAllowList.cpp:2 > + * Copyright (C) 2014, 2016, 2020 Apple Inc. All rights reserved. Just use "2014-2020" instead. > Source/JavaScriptCore/tools/FunctionAllowList.h:2 > + * Copyright (C) 2014, 2016, 2020 Apple Inc. All rights reserved. Ditto.
Saam Barati
Comment 6 2020-06-11 11:31:39 PDT
Comment on attachment 401659 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review >> Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:134 >> + allowlist = set(ObjCGenerator.DOMAINS_TO_GENERATE) > > Capitalize the L to be consistent with how we do it elsewhere? I should probably do allow_list to be consistent in this file.
Ross Kirsling
Comment 7 2020-06-11 11:35:37 PDT
Comment on attachment 401659 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review Personally I'd vote for a lowercase "l", but whichever works. > Source/JavaScriptCore/tools/FunctionAllowList.h:35 > +class FunctionWhitelist { Seems like this file got renamed but its contents weren't updated?
Saam Barati
Comment 8 2020-06-11 11:40:53 PDT
Comment on attachment 401659 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review >> Source/JavaScriptCore/tools/FunctionAllowList.h:35 >> +class FunctionAllowList { > > Seems like this file got renamed but its contents weren't updated? This is just bugzilla showing diff in two parts I believe
Saam Barati
Comment 9 2020-06-11 12:31:28 PDT
Created attachment 401669 [details] patch for landing
EWS
Comment 10 2020-06-11 15:47:26 PDT
Committed r262928: <https://trac.webkit.org/changeset/262928> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401669 [details].
Radar WebKit Bug Importer
Comment 11 2020-06-11 15:48:18 PDT
<rdar://problem/64273619>
Filip Pizlo
Comment 12 2020-07-15 12:46:56 PDT
R=me too.
Note You need to log in before you can comment on or make changes to this bug.