Bug 213050

Summary: [Cocoa] Return early from preference change notification handler if there is no observer
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2020-06-10 14:47:06 PDT
Currently, the observer member is checked inside the loop iterating over all the keys, but this check should be moved outside of the loop.
Attachments
Patch (1.99 KB, patch)
2020-06-10 14:49 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-06-10 14:49:03 PDT
Created attachment 401586 [details] Patch
Per Arne Vollan
Comment 2 2020-06-10 15:02:39 PDT
Comment on attachment 401586 [details] Patch Thanks for reviewing!
EWS
Comment 3 2020-06-10 15:34:39 PDT
Committed r262865: <https://trac.webkit.org/changeset/262865> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401586 [details].
Radar WebKit Bug Importer
Comment 4 2020-06-10 15:35:33 PDT
<rdar://problem/64227791>
Note You need to log in before you can comment on or make changes to this bug.