Summary: | [GTK] Scrolling glitches | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikael Tennhammar <mikael.tennhammar> | ||||||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | alp, hyatt | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | Linux | ||||||||||||||
Attachments: |
|
Description
Mikael Tennhammar
2008-10-02 03:57:04 PDT
Created attachment 24016 [details]
Changes in ScrollViewGtk to have teh view repainted
Comment on attachment 24016 [details]
Changes in ScrollViewGtk to have teh view repainted
r=me
Gtk had implemented the update() method incorrectly (when it was never meant to be an invalidate), so I guess this got caused by me fixing that.
I landed this with my next round of ScrollView changes in 37198. Created attachment 24046 [details]
Fix the repainting of the content when scrolling via the scrollbars
The current code do not make that SccrollView repaint itself. after scroll.
Note For the reviewer! I have only experience from GTK, but it seems clean to call the ScrollView's own method.
After latest updates of ScrollViewGtk the repainting of the view does not happen. Created attachment 24048 [details]
Fix the repainting of the content when scrolling via the scrollbars
The current code do not make that SccrollView repaint itself. after scroll.
Note For the reviewer! I have only experience from GTK, but it seems clean to
call the ScrollView's own method.
This is the same patch as the previous one, but there where some printout in the old one.
Created attachment 24049 [details]
Kill off more of ScrollViewGtk, fix GTK+ rendering issues
WebCore/ChangeLog | 42 ++++++
WebCore/platform/ScrollView.cpp | 18 --
WebCore/platform/ScrollView.h | 2
WebCore/platform/gtk/ScrollViewGtk.cpp | 180 +++++++-------------------
WebCore/platform/gtk/ScrollbarGtk.cpp | 110 ++++++++++-----
WebCore/platform/gtk/ScrollbarGtk.h | 5
WebKit/gtk/ChangeLog | 28 ++++
WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp | 50 ++++++-
WebKit/gtk/webkit/webkitwebview.cpp | 24 +++
9 files changed, 263 insertions(+), 196 deletions(-)
So, I took the recent breakage as an opportunity to fix invalidation/repaint issues we've had in the GTK+ port since the early days and kill off the cruft in ScrollViewGtk/ScrollViewPrivate (which are almost dead now).
Comment on attachment 24048 [details]
Fix the repainting of the content when scrolling via the scrollbars
Made obsolete by my fixes last night.
Comment on attachment 24049 [details]
Kill off more of ScrollViewGtk, fix GTK+ rendering issues
You need to merge this patch to ToT. I landed a fix for my Gtk autoscroll breakage last night. I think this patch is better than what I did... you just need to get merged to ToT to get a new patch for review.
ScrollbarGtk(ScrollbarClient*, ScrollbarOrientation, ScrollbarControlSize, GtkAdjustment* = 0); ScrollbarGtk is refcounted, so please make a create method instead and don't make your new constructor public. Comment on attachment 24016 [details]
Changes in ScrollViewGtk to have teh view repainted
Clearing review flag from this obsolete patch.
Created attachment 24484 [details]
Scrolling fixes
Comment on attachment 24484 [details]
Scrolling fixes
r=me
Landed in r37725. (Would still be nice to pick up the ScrollbarGtk cleanup changes some time later, they weren't in the patch.) |