Summary: | [buildbot] Add buildAndTest bot for WebKitGTK (GTK4) | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||||||||
Component: | New Bugs | Assignee: | Diego Pino <dpino> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | aakash_jain, clopez, ews-watchlist, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=215623 | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 210100 | ||||||||||||||
Attachments: |
|
Description
Diego Pino
2020-06-10 02:18:08 PDT
Created attachment 401524 [details]
Patch
Created attachment 401832 [details]
Patch
Created attachment 405356 [details]
Patch
Comment on attachment 405356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405356&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:89 > + { "name": "gtk-linux-bot-16", "platform": "gtk" }, Unfortunately I landed r266208 without realizing about this patch before. And I already picked gtk-linux-bot-16 in r266208. Can you please change the worker index number here to gtk-linux-bot-18 ? > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:354 > + "slavenames": ["gtk-linux-bot-16"] Ditto Created attachment 414005 [details]
Patch
Comment on attachment 414005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414005&action=review > Tools/CISupport/build-webkit-org/factories.py:179 > +class BuildAndTestAllButJSCFactory(TestAllButJSCFactory): > + def getProduct(self): > + self.addStep(CompileWebKit()) instead of inheriting from TestAllButJSCFactory and re-defining getProduct I would do this instead: class BuildAndTestAllButJSCFactory(BuildAndTestFactory): JSCTestClass = None Created attachment 414185 [details]
Patch
Committed r269945: <https://trac.webkit.org/changeset/269945> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414185 [details]. |