Summary: | WebKit:Add PepperUICoreSPI.h | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
Component: | Platform | Assignee: | Jonathan Bedard <jbedard> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aestes, ap, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=212718 | ||||||||||
Attachments: |
|
Description
Jonathan Bedard
2020-06-09 15:23:18 PDT
Created attachment 401483 [details]
Patch
Created attachment 401541 [details]
Patch
Comment on attachment 401541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401541&action=review > Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h:157 > +@property (nonatomic, assign) UIReturnKeyType returnKeyType; // Default is Done, also supports Send and Join I think we shouldn't be in the habit of importing comments from SPI headers. > Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h:280 > +@property (nonatomic) BOOL useWideIdleCheck; Do we really use all this stuff? I don't think so. We do. Nevermind. Comment on attachment 401541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401541&action=review >> Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h:157 >> +@property (nonatomic, assign) UIReturnKeyType returnKeyType; // Default is Done, also supports Send and Join > > I think we shouldn't be in the habit of importing comments from SPI headers. I mostly scrubbed them, missed this one. Created attachment 401558 [details]
Patch
Committed r262854: <https://trac.webkit.org/changeset/262854> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401558 [details]. Committed r262868: <https://trac.webkit.org/changeset/262868> Committed r262875: <https://trac.webkit.org/changeset/262875> |