Make updateScrollbars cross-platform

• Component: Platform
• Status: RESOLVED FIXED

[Dave Hyatt]

Make updateScrollbars cross-platform on ScrollView.

[Dave Hyatt]

Created attachment 24007 [details]
Patch

[Dave Hyatt]

Comment on attachment 24007 [details]
Patch

Never mind.  I need to remove more code.

[Dave Hyatt]

Created attachment 24008 [details]
Patch #2

[Dave Hyatt]

Created attachment 24009 [details]
Patch #3

[Sam Weinig]

Comment on attachment 24009 [details]
Patch #3

+        The ScrollView now implement ScrollbarClient, which means that there was a clash of windowClipRect methods from the
s/implement/implements/

+            }
+        }
+        else {
+            scrollsHorizontally = (hScroll == ScrollbarAuto) ? hasHorizontalScrollbar : (hScroll == ScrollbarAlwaysOn);

The else should be on the same line as the }.

+        if (pageStep < 0) pageStep = clientWidth;
This should be on two lines.

+        if (pageStep < 0) pageStep = clientHeight;
As should this

-// FIXME: ScrollViewPrivate will eventually be completely gone.  It's already gone on Mac.
-#if !PLATFORM(MAC)
+// FIXME: ScrollViewPrivate will eventually be completely gone.
I think this #if was incorrectly removed.

Otherwise, looks nice.  r=me.

[Dave Hyatt]

Fixed in r37198.