Bug 212970

Summary: BaseAudioSharedUnit should unmute its clients in case of suspension even if not having any audio unit
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2020-06-09 06:30:35 PDT
BaseAudioSharedUnit should unmute its clients in case of suspension even if not having any audio unit
Attachments
Patch (13.81 KB, patch)
2020-06-09 06:41 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (13.81 KB, patch)
2020-06-09 08:37 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-06-09 06:31:30 PDT
<rdar://problem/64161891>
youenn fablet
Comment 2 2020-06-09 06:41:52 PDT
Created attachment 401437 [details] Patch
Eric Carlson
Comment 3 2020-06-09 07:15:35 PDT
Comment on attachment 401437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401437&action=review > Source/WebCore/ChangeLog:9 > + This will, in turn, make the BaseAudioSharedUnit to stop and no longer have any audio unit. s/the BaseAudioSharedUnit to stop/the BaseAudioSharedUnit stop/ > Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:179 > + ASSERT(!m_producingCount); Is this backwards?
youenn fablet
Comment 4 2020-06-09 08:36:57 PDT
Comment on attachment 401437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401437&action=review >> Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:179 >> + ASSERT(!m_producingCount); > > Is this backwards? Given the current model, m_producingCount should be zero. I guess I could remove the if(m_producingCount) check.
youenn fablet
Comment 5 2020-06-09 08:37:21 PDT
Created attachment 401442 [details] Patch
Eric Carlson
Comment 6 2020-06-09 08:51:14 PDT
Comment on attachment 401442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401442&action=review > Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:180 > if (m_producingCount) { This is confusing given the assert.
youenn fablet
Comment 7 2020-06-09 11:03:51 PDT
(In reply to Eric Carlson from comment #6) > Comment on attachment 401442 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401442&action=review > > > Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:180 > > if (m_producingCount) { > > This is confusing given the assert. Will remove it in a follow-up
EWS
Comment 8 2020-06-09 11:16:13 PDT
Committed r262798: <https://trac.webkit.org/changeset/262798> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401442 [details].
Note You need to log in before you can comment on or make changes to this bug.