Bug 212967

Summary: scrollingcoordinator/ios/scroll-position-after-reattach.html is a flaky image failure
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CompositingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2020-06-09 04:27:15 PDT
flake
Attachments
patch (2.44 KB, patch)
2020-06-09 04:32 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-06-09 04:27:27 PDT
<rdar://problem/52961406>
Antti Koivisto
Comment 2 2020-06-09 04:32:22 PDT
Created attachment 401434 [details] patch
Antoine Quint
Comment 3 2020-06-09 05:37:57 PDT
Comment on attachment 401434 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401434&action=review > LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:33 > let removed = outercontent; > outercontent.remove(); While you're modifying this test, you can remove the `removed` variable which is useless, `outercontent` can be used. > LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:36 > + await new Promise(requestAnimationFrame); Since this test is already pulling in `UIHelper`, you can use `UIHelper.animationFrame()`.
Antti Koivisto
Comment 4 2020-06-09 05:42:15 PDT
Comment on attachment 401434 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=401434&action=review >> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:33 >> outercontent.remove(); > > While you're modifying this test, you can remove the `removed` variable which is useless, `outercontent` can be used. You'd think so but 'outercontent' is not a variable. It is an implicit property on window object.
EWS
Comment 5 2020-06-09 05:57:27 PDT
Committed r262789: <https://trac.webkit.org/changeset/262789> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401434 [details].
Note You need to log in before you can comment on or make changes to this bug.