Bug 212932

Summary: WebKit.ShrinkToFit is failing on some bots
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, pvollan, ryanhaddad, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2020-06-08 15:57:12 PDT
WebKit.ShrinkToFit is failing on some bots
Attachments
Patch (4.88 KB, patch)
2020-06-08 15:57 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (4.90 KB, patch)
2020-06-08 16:05 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (5.80 KB, patch)
2020-06-09 11:05 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-06-08 15:57:32 PDT
Created attachment 401389 [details] Patch
Tim Horton
Comment 2 2020-06-08 15:57:34 PDT
<rdar://problem/60972407>
Simon Fraser (smfr)
Comment 3 2020-06-08 15:59:48 PDT
Comment on attachment 401389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401389&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:66 > + // This is 85 instead of 100 because we now have a scrollbar. Does the "now" refer to "after this fix" or "now that the test has done something"? Remove it if the former.
Tim Horton
Comment 4 2020-06-08 16:05:02 PDT
The latter. I will clarify the comment.
Tim Horton
Comment 5 2020-06-08 16:05:56 PDT
Created attachment 401390 [details] Patch
Tim Horton
Comment 6 2020-06-09 11:05:13 PDT
Created attachment 401452 [details] Patch
EWS
Comment 7 2020-06-09 11:46:25 PDT
Committed r262800: <https://trac.webkit.org/changeset/262800> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401452 [details].
Darin Adler
Comment 8 2020-06-09 11:52:28 PDT
Comment on attachment 401452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401452&action=review > Tools/TestWebKitAPI/mac/mainMac.mm:43 > + // CAUTION: Defaults set here are not automatically propagated to the > + // Web Content process. Those listed below are propagated manually. I find this comment slightly mysterious. After reading the patch and the comments in the bug, I think we mean that WebKit *itself* happens to propagate all of these (maybe a pointer to the code that does it would help since this test tool *is* part of WebKit), but we could also be referring to some other part of TestWebKitAPI doing it.
Tim Horton
Comment 9 2020-06-09 13:58:13 PDT
Comment on attachment 401452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401452&action=review >> Tools/TestWebKitAPI/mac/mainMac.mm:43 >> + // Web Content process. Those listed below are propagated manually. > > I find this comment slightly mysterious. After reading the patch and the comments in the bug, I think we mean that WebKit *itself* happens to propagate all of these (maybe a pointer to the code that does it would help since this test tool *is* part of WebKit), but we could also be referring to some other part of TestWebKitAPI doing it. I did mean WebKit, yes. Mostly trying to call out "if you add another default here it will not magically make it to the WP". Maybe it can be reworded.
Note You need to log in before you can comment on or make changes to this bug.