Bug 212929

Summary: Remove unnecessary variable in `WindowProxy::createJSWindowProxy`
Product: WebKit Reporter: Devin Rousso <hi>
Component: BindingsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, hi, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2020-06-08 15:42:39 PDT
``` Strong<JSWindowProxy> jsWindowProxy(vm, &JSWindowProxy::create(vm, *m_frame->window(), world)); Strong<JSWindowProxy> jsWindowProxy2(jsWindowProxy); ``` Nothing seems to use `jsWindowProxy2`, so it should be removed (or have a comment as to why it's needed). This was added in r78634 <https://webkit.org/b/54415> 🤯
Attachments
Patch (1.32 KB, patch)
2020-06-08 15:43 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-06-08 15:43:39 PDT
Created attachment 401384 [details] Patch
EWS
Comment 2 2020-06-08 16:23:00 PDT
Committed r262751: <https://trac.webkit.org/changeset/262751> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401384 [details].
Radar WebKit Bug Importer
Comment 3 2020-06-08 16:23:21 PDT
<rdar://problem/64139773>
Note You need to log in before you can comment on or make changes to this bug.