Bug 212917

Summary: Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2020-06-08 13:24:07 PDT
Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()
Attachments
Patch (6.85 KB, patch)
2020-06-08 13:31 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (7.31 KB, patch)
2020-06-08 16:06 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (6.86 KB, patch)
2020-06-08 16:12 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-06-08 13:31:28 PDT
Created attachment 401365 [details] Patch
EWS
Comment 2 2020-06-08 14:35:57 PDT
Tools/Scripts/svn-apply failed to apply attachment 401365 [details] to trunk. Please resolve the conflicts and upload a new patch.
Sam Weinig
Comment 3 2020-06-08 16:06:32 PDT
Created attachment 401391 [details] Patch
EWS
Comment 4 2020-06-08 16:08:31 PDT
ChangeLog entry in Tools/ChangeLog contains OOPS!.
Sam Weinig
Comment 5 2020-06-08 16:12:24 PDT
Created attachment 401393 [details] Patch
Darin Adler
Comment 6 2020-06-08 16:30:30 PDT
Comment on attachment 401393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401393&action=review > Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp:222 > + auto cLigtened = Color(c).lightened().toSRGBASimpleColorLossy(); typo in existing code: "ligtened"
Sam Weinig
Comment 7 2020-06-08 16:40:22 PDT
(In reply to Darin Adler from comment #6) > Comment on attachment 401393 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401393&action=review > > > Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp:222 > > + auto cLigtened = Color(c).lightened().toSRGBASimpleColorLossy(); > > typo in existing code: "ligtened" Gaaaaa :). I'll get it right one of these times.
EWS
Comment 8 2020-06-08 17:11:00 PDT
Committed r262753: <https://trac.webkit.org/changeset/262753> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401393 [details].
Radar WebKit Bug Importer
Comment 9 2020-06-08 17:11:18 PDT
<rdar://problem/64141679>
Note You need to log in before you can comment on or make changes to this bug.