Bug 212880

Summary: Simplify fallback content handling in FrameLoader
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, japhet, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2020-06-07 07:17:29 PDT
Simplify fallback content handling in FrameLoader, this can be inlined and some HTMLObjectElement checks can be combined.
Attachments
Patch (6.47 KB, patch)
2020-06-07 07:18 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (6.49 KB, patch)
2020-06-08 01:21 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-06-07 07:18:40 PDT
Created attachment 401293 [details] Patch
youenn fablet
Comment 2 2020-06-08 00:50:57 PDT
Comment on attachment 401293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401293&action=review > Source/WebCore/loader/DocumentLoader.cpp:1011 > + HTMLFrameOwnerElement* owner = m_frame->ownerElement(); auto*
Rob Buis
Comment 3 2020-06-08 01:21:57 PDT
Created attachment 401316 [details] Patch
EWS
Comment 4 2020-06-08 02:04:38 PDT
Committed r262704: <https://trac.webkit.org/changeset/262704> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401316 [details].
Radar WebKit Bug Importer
Comment 5 2020-06-08 02:05:19 PDT
<rdar://problem/64111590>
Radar WebKit Bug Importer
Comment 6 2020-06-08 02:05:23 PDT
<rdar://problem/64111592>
Note You need to log in before you can comment on or make changes to this bug.