Bug 212880

Summary: Simplify fallback content handling in FrameLoader
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, japhet, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Rob Buis 2020-06-07 07:17:29 PDT 
Simplify fallback content handling in FrameLoader, this can be inlined
and some HTMLObjectElement checks can be combined.
Comment 1 Rob Buis 2020-06-07 07:18:40 PDT 
Created attachment 401293 [details]
Patch
Comment 2 youenn fablet 2020-06-08 00:50:57 PDT 
Comment on attachment 401293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401293&action=review

> Source/WebCore/loader/DocumentLoader.cpp:1011
> +            HTMLFrameOwnerElement* owner = m_frame->ownerElement();

auto*
Comment 3 Rob Buis 2020-06-08 01:21:57 PDT 
Created attachment 401316 [details]
Patch
Comment 4 EWS 2020-06-08 02:04:38 PDT 
Committed r262704: <https://trac.webkit.org/changeset/262704>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401316 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-08 02:05:19 PDT 
<rdar://problem/64111590>
Comment 6 Radar WebKit Bug Importer 2020-06-08 02:05:23 PDT 
<rdar://problem/64111592>