Bug 212872

Summary: Extended Color: Replace uses of differenceSquared() with luminance based computations
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, dino, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2020-06-06 18:34:20 PDT
[Color] Replace uses of differenceSquared() with luminance based computations
Attachments
Patch (10.45 KB, patch)
2020-06-06 18:35 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (10.44 KB, patch)
2020-06-07 07:54 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (10.69 KB, patch)
2020-06-07 10:18 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (10.74 KB, patch)
2020-06-07 11:00 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (15.33 KB, patch)
2020-06-07 13:21 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (15.23 KB, patch)
2020-06-07 17:54 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-06-06 18:35:14 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-06-07 07:54:15 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2020-06-07 10:18:46 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2020-06-07 11:00:04 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2020-06-07 13:21:01 PDT Comment hidden (obsolete)
Sam Weinig
Comment 6 2020-06-07 17:54:32 PDT
Created attachment 401307 [details] Patch
Darin Adler
Comment 7 2020-06-08 11:23:24 PDT
Comment on attachment 401307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401307&action=review > Source/WebCore/platform/graphics/Color.h:139 > + WEBCORE_EXPORT Color lighten() const; > + WEBCORE_EXPORT Color darken() const; A Cocoa-style name would be lightened/darkened or lightened/darkenedColor.
EWS
Comment 8 2020-06-08 11:38:37 PDT
Committed r262729: <https://trac.webkit.org/changeset/262729> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401307 [details].
Radar WebKit Bug Importer
Comment 9 2020-06-08 11:39:20 PDT
<rdar://problem/64128197>
Note You need to log in before you can comment on or make changes to this bug.