Bug 212872

Summary: Extended Color: Replace uses of differenceSquared() with luminance based computations
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, dino, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Sam Weinig 2020-06-06 18:34:20 PDT 
[Color] Replace uses of differenceSquared() with luminance based computations
Comment 1 Sam Weinig 2020-06-06 18:35:14 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-06-07 07:54:15 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-06-07 10:18:46 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-06-07 11:00:04 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-06-07 13:21:01 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-06-07 17:54:32 PDT 
Created attachment 401307 [details]
Patch
Comment 7 Darin Adler 2020-06-08 11:23:24 PDT 
Comment on attachment 401307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401307&action=review

> Source/WebCore/platform/graphics/Color.h:139
> +    WEBCORE_EXPORT Color lighten() const;
> +    WEBCORE_EXPORT Color darken() const;

A Cocoa-style name would be lightened/darkened or lightened/darkenedColor.
Comment 8 EWS 2020-06-08 11:38:37 PDT 
Committed r262729: <https://trac.webkit.org/changeset/262729>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401307 [details].
Comment 9 Radar WebKit Bug Importer 2020-06-08 11:39:20 PDT 
<rdar://problem/64128197>