Bug 212830

Summary: -_focusTextInputContext should reposition the caret if called for an already focused text input context
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
To land none

Daniel Bates
Reported 2020-06-05 09:50:45 PDT
Update the code based on new feedback. -_focusTextInputContext should reposition the caret if called for an already focused text input context.
Attachments
Patch (11.69 KB, patch)
2020-06-05 10:17 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To land (12.04 KB, patch)
2020-06-05 10:30 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-06-05 09:50:59 PDT
<rdar://problem/64032956>
Daniel Bates
Comment 2 2020-06-05 10:17:27 PDT
Created attachment 401169 [details] Patch
Wenson Hsieh
Comment 3 2020-06-05 10:21:18 PDT
Comment on attachment 401169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401169&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4297 > + _pointInsideLastFocusedTextInputContext = WTF::nullopt; Should we also reset this in `-cleanUpInteraction`?
Daniel Bates
Comment 4 2020-06-05 10:27:35 PDT
Comment on attachment 401169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401169&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4297 >> + _pointInsideLastFocusedTextInputContext = WTF::nullopt; > > Should we also reset this in `-cleanUpInteraction`? Yes, of course
Daniel Bates
Comment 5 2020-06-05 10:27:47 PDT
Comment on attachment 401169 [details] Patch Thanks for the review!
Daniel Bates
Comment 6 2020-06-05 10:30:43 PDT
Created attachment 401170 [details] To land
Daniel Bates
Comment 7 2020-06-05 14:29:11 PDT
Comment on attachment 401170 [details] To land Clearing flags on attachment: 401170 Committed r262654: <https://trac.webkit.org/changeset/262654>
Daniel Bates
Comment 8 2020-06-05 14:29:13 PDT
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 9 2020-06-27 15:50:16 PDT
(In reply to Daniel Bates from comment #7) > Comment on attachment 401170 [details] > To land > > Clearing flags on attachment: 401170 > > Committed r262654: <https://trac.webkit.org/changeset/262654> This was wrong and caused <rdar://problem/64664156>. Reverting...
Daniel Bates
Comment 10 2020-06-27 15:59:53 PDT
(In reply to Daniel Bates from comment #9) > (In reply to Daniel Bates from comment #7) > > Comment on attachment 401170 [details] > > To land > > > > Clearing flags on attachment: 401170 > > > > Committed r262654: <https://trac.webkit.org/changeset/262654> > > > This was wrong and caused <rdar://problem/64664156>. Reverting... Reverted in <https://trac.webkit.org/changeset/263630>
Note You need to log in before you can comment on or make changes to this bug.