URLs clicked on from -[WKWebView _showSafeBrowsingWarningWithURL:title:warning:details:completionHandler:] are ignored

• Component: New Bugs
• Status: RESOLVED FIXED

[Richard Houle]

Created attachment 401122 [details]
Proposed fix

For more information about the Safari specific issue, please read <rdar://problem/63027631>.

[Alexey Proskuryakov]

Comment on attachment 401122 [details]
Proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=401122&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2155
> -- (void)_showSafeBrowsingWarningWithTitle:(NSString *)title warning:(NSString *)warning details:(NSAttributedString *)details completionHandler:(void(^)(BOOL))completionHandler

This changes and removes SPI, will it break using ToT WebKit with shipping Safari?

[Richard Houle]

It will.

I will submit a modified patch that keeps compatibility with shipping Safari.

[Richard Houle]

Created attachment 401350 [details]
Proposed fix V2

[Alex Christensen]

Comment on attachment 401350 [details]
Proposed fix V2

You should use WK_MAC_TBA and WK_IOS_TBA in the WK_API_AVAILABLE macros.
You should also add a ChangeLog entry with the change.

[Richard Houle]

Created attachment 401351 [details]
Proposed fix V3

[Alex Christensen]

You need to change the file Source/WebKit/ChangeLog

[Richard Houle]

Created attachment 401352 [details]
Proposed fix V4

[EWS]

Committed r262732: <https://trac.webkit.org/changeset/262732>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401352 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64129665>