Bug 212797

Summary:

[WPE] Behave like GDK_CURRENT_TIME when the timestamp is zero

Product:

WebKit

Reporter:

Lauro Moura <lmoura>

Component:

WPE WebKit

Assignee:

Lauro Moura <lmoura>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bugs-noreply, cgarcia

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cgarcia: review+, cgarcia: commit-queue-

Lauro Moura

Reported 2020-06-04 21:03:15 PDT

When the timestamp is zero, use WallTime::now() as the event time. Zero timestamps can happen in the WebDriver tests. Follow up to bug212338.

Attachments
Patch (1.53 KB, patch) 2020-06-04 21:06 PDT, Lauro Moura	cgarcia: review+ cgarcia: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Lauro Moura

Comment 1 2020-06-04 21:06:53 PDT

Adrian Perez

Comment 2 2020-06-05 14:41:15 PDT

Comment on attachment 401115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401115&action=review > Source/WebKit/Shared/libwpe/WebEventFactory.cpp:68 > + return WallTime::now(); I *think* that this is right, but I would prefer that Carlos García confirms =)

Carlos Garcia Campos

Comment 3 2020-06-06 05:12:13 PDT

Comment on attachment 401115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401115&action=review > Source/WebKit/Shared/libwpe/WebEventFactory.cpp:66 > + // Behave like GDK_CURRENT_TIME I would remove this comment, it might be confusing. Or I would say something like 0 means current time.

Lauro Moura

Comment 4 2020-06-07 17:16:45 PDT

Note You need to log in before you can comment on or make changes to this bug.