Bug 212796

Summary: WTF: Exclude MachExceptions.defs from all embedded builds
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Web Template FrameworkAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212718
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2020-06-04 19:58:53 PDT
MachExceptions.defs is excluded from OpenSource iPhone builds, and should also be excluded from other OpenSource embedded builds.
Attachments
Patch (1.69 KB, patch)
2020-06-04 20:11 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.34 KB, patch)
2020-06-04 21:18 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-06-04 20:11:09 PDT
Created attachment 401113 [details] Patch
Alexey Proskuryakov
Comment 2 2020-06-04 20:48:00 PDT
Comment on attachment 401113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401113&action=review > Source/WTF/ChangeLog:10 > +2020-06-04 Jonathan Bedard <jbedard@apple.com> Extra change log. > Source/WTF/Configurations/WTF.xcconfig:-35 > -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks This seems unrelated. > Source/WTF/Configurations/WTF.xcconfig:32 > +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK)); This includes simulator, correct?
Jonathan Bedard
Comment 3 2020-06-04 21:18:19 PDT
Created attachment 401117 [details] Patch
Jonathan Bedard
Comment 4 2020-06-04 22:02:58 PDT
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 401113 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401113&action=review > > > Source/WTF/ChangeLog:10 > > +2020-06-04 Jonathan Bedard <jbedard@apple.com> > > Extra change log. > > > Source/WTF/Configurations/WTF.xcconfig:-35 > > -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks > > This seems unrelated. > > > Source/WTF/Configurations/WTF.xcconfig:32 > > +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK)); > > This includes simulator, correct? It does, this same pattern will show up a few more times in other xcconfig files.
EWS
Comment 5 2020-06-04 22:29:10 PDT
Committed r262597: <https://trac.webkit.org/changeset/262597> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401117 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-05 09:58:24 PDT
<rdar://problem/64033297>
Note You need to log in before you can comment on or make changes to this bug.