Bug 212793

Summary: [JSC] Report extra memory allocation from PropertyTable
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2020-06-04 17:21:21 PDT
[JSC] Report extra memory allocation from PropertyTable
Attachments
Patch (9.10 KB, patch)
2020-06-04 17:22 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-06-04 17:22:20 PDT
Created attachment 401100 [details] Patch
Yusuke Suzuki
Comment 2 2020-06-04 18:22:50 PDT
Comment on attachment 401100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401100&action=review > Source/JavaScriptCore/runtime/PropertyMapHashTable.h:531 > + vm.heap.reportExtraMemoryAllocated(dataSize()); Maybe, we should report if (oldDataSize < dataSize()) vm.heap.reportExtraMemoryAllocated(dataSize() - oldDataSize); changed.
Yusuke Suzuki
Comment 3 2020-06-04 22:55:27 PDT
Ran jsc tests locally.
Yusuke Suzuki
Comment 4 2020-06-04 22:59:02 PDT
Committed r262600: <https://trac.webkit.org/changeset/262600>
Radar WebKit Bug Importer
Comment 5 2020-06-05 09:58:15 PDT
<rdar://problem/64033289>
Note You need to log in before you can comment on or make changes to this bug.