Bug 212793

Summary:

[JSC] Report extra memory allocation from PropertyTable

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	saam: review+

Description Yusuke Suzuki 2020-06-04 17:21:21 PDT

[JSC] Report extra memory allocation from PropertyTable

Comment 1 Yusuke Suzuki 2020-06-04 17:22:20 PDT

Created attachment 401100 [details]
Patch

Comment 2 Yusuke Suzuki 2020-06-04 18:22:50 PDT

Comment on attachment 401100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401100&action=review

> Source/JavaScriptCore/runtime/PropertyMapHashTable.h:531
> +    vm.heap.reportExtraMemoryAllocated(dataSize());

Maybe, we should report

if (oldDataSize < dataSize())
    vm.heap.reportExtraMemoryAllocated(dataSize() - oldDataSize);

changed.

Comment 3 Yusuke Suzuki 2020-06-04 22:55:27 PDT

Ran jsc tests locally.

Comment 4 Yusuke Suzuki 2020-06-04 22:59:02 PDT

Committed r262600: <https://trac.webkit.org/changeset/262600>

Comment 5 Radar WebKit Bug Importer 2020-06-05 09:58:15 PDT

<rdar://problem/64033289>