Bug 212773

Summary: Add Options::validateDoesGC() for turning DoesGC validation on/off.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2020-06-04 13:15:36 PDT
It will default to on if ASSERT_ENABLED because we want testing to be done with the validation on. When needed, we can turn it off if we need to e.g. to de-clutter disassembly dumps while debugging.
Attachments
proposed patch. (21.40 KB, patch)
2020-06-04 13:28 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-06-04 13:28:21 PDT
Created attachment 401073 [details] proposed patch.
Mark Lam
Comment 2 2020-06-04 14:09:30 PDT
Thanks for the review. I added some details to the ChangeLog. Landed in r262570: <http://trac.webkit.org/r262570>.
Radar WebKit Bug Importer
Comment 3 2020-06-04 14:10:15 PDT
<rdar://problem/63994958>
Note You need to log in before you can comment on or make changes to this bug.