Bug 212773 - Add Options::validateDoesGC() for turning DoesGC validation on/off.
Summary: Add Options::validateDoesGC() for turning DoesGC validation on/off.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-04 13:15 PDT by Mark Lam
Modified: 2020-06-04 14:10 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch. (21.40 KB, patch)
2020-06-04 13:28 PDT, Mark Lam
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-06-04 13:15:36 PDT
It will default to on if ASSERT_ENABLED because we want testing to be done with the validation on.  When needed, we can turn it off if we need to e.g. to de-clutter disassembly dumps while debugging.
Comment 1 Mark Lam 2020-06-04 13:28:21 PDT
Created attachment 401073 [details]
proposed patch.
Comment 2 Mark Lam 2020-06-04 14:09:30 PDT
Thanks for the review.  I added some details to the ChangeLog.

Landed in r262570: <http://trac.webkit.org/r262570>.
Comment 3 Radar WebKit Bug Importer 2020-06-04 14:10:15 PDT
<rdar://problem/63994958>