Bug 212716

Summary: Inserted text placeholder should vertically align to top and behave like block-level element when it has 0 width
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
To Land none

Daniel Bates
Reported 2020-06-03 14:49:58 PDT
Update appearance of text placeholder based on feedback. Two changes 1. Vertically align top the placeholder 2. Placeholder should be on its own line when its width is 0: behave like a block-level element.
Attachments
Patch (9.80 KB, patch)
2020-06-03 15:04 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To Land (9.81 KB, patch)
2020-06-03 17:01 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-06-03 14:50:18 PDT
<rdar://problem/62672479>
Daniel Bates
Comment 2 2020-06-03 15:04:03 PDT
Created attachment 400970 [details] Patch
Daniel Bates
Comment 3 2020-06-03 15:06:27 PDT
Comment on attachment 400970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400970&action=review > Source/WebCore/ChangeLog:9 > + Refine the appearance of text placeholder based on feedback: of => of a
Daniel Bates
Comment 4 2020-06-03 15:26:49 PDT
Thanks Darin!
Daniel Bates
Comment 5 2020-06-03 17:01:31 PDT
Created attachment 400983 [details] To Land
Daniel Bates
Comment 6 2020-06-03 17:02:02 PDT
Committed r262525: <https://trac.webkit.org/changeset/262525>
Note You need to log in before you can comment on or make changes to this bug.